| Ourselves Alone
Terence Elliott | 1936 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | Edge of the World
Andrew Gray, James' Son | 1937 |
 | 49th Parallel
Vogel | 1941 |
| East of Piccadilly | 1941 |
| Day Will Dawn
Olaf | 1942 |
| Undercover
Dr. Jordon | 1943 |
 | We Dive at Dawn
Chief Petty Officer Mike 'T.I.' Corrigan, Torpedo Gunner's Mate | 1943 |
| Tawny Pipit
Jimmy Bancroft | 1944 |
| Hundred Pound Window
Chick Slater | 1944 |
 | Henry V
Captain MacMorris | 1944 |
| Captain Boycott | 1947 |
 | Anna Karenina
Konstantin Levin | 1948 |
| Hamlet
Sea Captain | 1948 |
| No Room at the Inn
O'Rane | 1948 |
| Which Will Ye Have?
Barabbas | 1949 |
| Diamond City
Muller | 1949 |
| Christopher Columbus
Juan de la Cosa | 1949 |
 | Chance of a Lifetime
Baxter | 1950 |
| Talk of a Million
Tom Cassidy | 1951 |
| Murder in the Cathedral
Herald | 1951 |
 | No Highway in the Sky
Captain "Sam" Samuelson
(uncredited) | 1951 |
| Martin Luther
Martin Luther | 1953 |
| Hell Below Zero
Doctor Howe | 1953 |
| Knights of the Round Table
Green Knight | 1953 |
| Betrayed
"Blackie" | 1954 |
| Conflict of Wings
Harry Tilney (as Niall Macginnis) | 1954 |
| Special Delivery | 1955 |
| Lust for Life
Roulin | 1956 |
| Alexander the Great
Parmenio | 1956 |
| Helen of Troy
Menelaus | 1956 |
| Behind the Mask | 1958 |
 | Night of the Demon
Dr. Karswell | 1958 |
| Jack the Ripper
Walter | 1958 |
| She Didn't Say No
James Casey | 1958 |
| Shake Hands With the Devil
Michael O'Leary | 1959 |
| Tarzan's Greatest Adventure
Kruger | 1959 |
| Nun's Story
Father Vermeuhlen | 1959 |
| Kidnapped
Mr. Shaun | 1960 |
| Sword of Sherwood Forest
Friar Tuck | 1960 |
| Never Take Sweets from a Stranger
Defense Counsel | 1960 |
 | Foxhole in Cairo
Morris Radek | 1960 |
| Johnny Nobody | 1961 |
| Billy Budd
Captain Graveling | 1962 |
| Man Who Finally Died
Brenner | 1962 |
| Playboy of the Western World | 1962 |
| Face in the Rain | 1963 |
 | Jason and the Argonauts
Zeus | 1963 |
| Becket
Baron | 1964 |
| Truth About Spring
Cleary | 1964 |
| War Lord
Odins | 1965 |
 | Spy Who Came in From the Cold
Checkpoint Charlie Guard | 1965 |
| Man Could Get Killed
Ship's Captain | 1966 |
 | Island of Terror
Roger Campbell | 1966 |
 | Viking Queen
Tiberion | 1967 |
| Torture Garden
Doctor | 1968 |
| Shoes of the Fisherman
Capuchin Monk | 1968 |
| Sinful Davey
Boots Simpson (as Niall MacGinniss) | 1969 |
| Krakatoa, East of Java
Harbor Master | 1969 |
| Kremlin Letter
Erector Set | 1970 |
| River of Mystery
Garwood Drum | 1971 |
 | Mackintosh Man
Warder | 1973 |